allows manifest file to be parameterized #1578
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
fixes #1382 - manifest json file is hard coded to be laravel-mix specific.
Description
This patch allows src/app.cr in a generated application to be changed to this:
For folks using rollup, parcel, vite, or whatever hot javascript packaging engine suits them, this top level hook for replacing the manifest file is important.
Notably, this doesn't require the change to app.cr so this isn't a breaking change. It just provides an API where non existed before.
Checklist
crystal tool format spec src
./script/setup
./script/test