Add previous_page and next_page methods to paginator #1611
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Adds
previous_page
andnext_page
methods toLucky::Paginator
.(Sorry for not opening an issue first, but this seems like such an obvious addition).
Description
Currently, there are only the
path_to_next
andpath_to_previous
methods, returning a path including all query params. There's no way to get the next/previous page number other than calculating it based on the values returned by thepaginator.page
andpaginator.total
methods.I'm working on an API and I need pagination with the full url and without any additional query parameters that may be present. To build the url, I need the previous and next page numbers rather than the paths.
Checklist
crystal tool format spec src
./script/setup
./script/test