Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract lucky_avram and remove avram dependency #1620

Merged
merged 2 commits into from
May 1, 2022

Conversation

matthewmcgarvey
Copy link
Member

@matthewmcgarvey matthewmcgarvey commented Nov 22, 2021

This is one of the last parts to making Avram optional in Lucky.
The code removed from here will be moved to avram luckyframework/avram#772
The moved code will be accessible to apps by adding additional requires and the lucky_cli change can be found here luckyframework/lucky_cli#711

This whole thing is a breaking change but in a minor way. Currently, having require "lucky" in your code pulled in all this code and also brought in avram. To get the same functionality, code will need to be updated to

require "lucky"
require "avram"
require "avram/lucky"

And then the tasks will also need to be imported in your tasks.cr file

require "avram/lucky/tasks"

Copy link
Member

@jwoertink jwoertink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for getting this started. I'm going to move forward with it now. This will allow people to use Lucky without a DB, or even use a different ORM if they'd like with a proper escape hatch. I think this will also make testing the lucky-avram bridge a lot easier with this code being closer to home.

@jwoertink jwoertink merged commit 88b897a into luckyframework:main May 1, 2022
@jwoertink jwoertink mentioned this pull request Aug 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BREAKING CHANGE This will cause a breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants