Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More accurately parse json values for params #1661

Merged
merged 1 commit into from
Feb 1, 2022
Merged

More accurately parse json values for params #1661

merged 1 commit into from
Feb 1, 2022

Conversation

matthewmcgarvey
Copy link
Member

Purpose

In the cases where the value of a json field is a JSON object, it was inaccurately returning the string representation of the hash instead of the JSON object. So, instead of calling .to_s on JSON::Any we call .to_json with one caveat and that is String values. Calling .to_json on a string wraps the string in escaped quotes.

@matthewmcgarvey matthewmcgarvey mentioned this pull request Jan 31, 2022
Closed
jwoertink
jwoertink approved these changes Feb 1, 2022
View reviewed changes
Copy link
Member

@jwoertink jwoertink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@matthewmcgarvey matthewmcgarvey merged commit ecf19a0 into luckyframework:master Feb 1, 2022
@matthewmcgarvey matthewmcgarvey deleted the params-json-parsing branch February 1, 2022 04:10
@matthewmcgarvey matthewmcgarvey mentioned this pull request Feb 1, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jwoertink jwoertink jwoertink approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@matthewmcgarvey @jwoertink