Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure to check the arg type restrictions for the memoize. #1726

Merged
merged 1 commit into from
Aug 29, 2022

Conversation

jwoertink
Copy link
Member

Purpose

Fixes #1722

Description

A macro Arg uses the restriction method to check if it's a Nop.

Checklist

  • - An issue already exists detailing the issue/or feature request that this PR fixes
  • - All specs are formatted with crystal tool format spec src
  • - Inline documentation has been added and/or updated
  • - Lucky builds on docker with ./script/setup
  • - All builds and specs pass on docker with ./script/test

@jwoertink jwoertink merged commit e60f982 into main Aug 29, 2022
@jwoertink jwoertink deleted the issues/1722 branch August 29, 2022 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Forgetting a type restriction on an arg when using memoize has a bad error
2 participants