Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENV to override the server host #1788

Merged
merged 1 commit into from
Mar 10, 2023
Merged

ENV to override the server host #1788

merged 1 commit into from
Mar 10, 2023

Conversation

jwoertink
Copy link
Member

Purpose

Fixes #1787

Description

This adds the option to override the server host by using an ENV. We've had the ability to do this for the PORT for a while now, so it made sense to add host too.

Checklist

  • - An issue already exists detailing the issue/or feature request that this PR fixes
  • - All specs are formatted with crystal tool format spec src
  • - Inline documentation has been added and/or updated
  • - Lucky builds on docker with ./script/setup
  • - All builds and specs pass on docker with ./script/test

@jwoertink jwoertink merged commit 8e25d16 into main Mar 10, 2023
@jwoertink jwoertink deleted the issues/1787 branch March 10, 2023 23:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow for overriding the local host
1 participant