Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing memoized methods using external arg names. #1817

Merged
merged 2 commits into from
Aug 11, 2023
Merged

Fixing memoized methods using external arg names. #1817

merged 2 commits into from
Aug 11, 2023

Conversation

jwoertink
Copy link
Member

Purpose

Fixes #1814

Description

When you memoize a method that uses external arg names like foo(out in : String) : String it currently doesn't compile. This PR fixes that.

Checklist

  • - An issue already exists detailing the issue/or feature request that this PR fixes
  • - All specs are formatted with crystal tool format spec src
  • - Inline documentation has been added and/or updated
  • - Lucky builds on docker with ./script/setup
  • - All builds and specs pass on docker with ./script/test

robacarp
robacarp approved these changes Jul 24, 2023
View reviewed changes
Copy link
Contributor

@robacarp robacarp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@jwoertink jwoertink merged commit d60191e into main Aug 11, 2023
4 of 5 checks passed
@jwoertink jwoertink deleted the issues/1814 branch August 11, 2023 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewmcgarvey matthewmcgarvey matthewmcgarvey approved these changes

@robacarp robacarp robacarp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

memoize doesn't work when there's an external name
3 participants
@jwoertink @robacarp @matthewmcgarvey