Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Browser and Page tasks. Added new --with-page flag #1819

Merged
merged 1 commit into from
Sep 1, 2023
Merged

Refactor Browser and Page tasks. Added new --with-page flag #1819

merged 1 commit into from
Sep 1, 2023

Conversation

jwoertink
Copy link
Member

Purpose

Fixes #1795

Description

This adds in a new --with-page CLI flag for the Browser action generator that allows you to generate a page along with the action.

lucky gen.action.browser Reports::Index --with-page

In order to do this, I had to refactor both the action and the page tasks (#1247) just a bit.

Checklist

  • - An issue already exists detailing the issue/or feature request that this PR fixes
  • - All specs are formatted with crystal tool format spec src
  • - Inline documentation has been added and/or updated
  • - Lucky builds on docker with ./script/setup
  • - All builds and specs pass on docker with ./script/test

@jwoertink
Refactor Page and Action generators to use newer LuckyTask CLI interf…
bb580f6 
…ace. Adding new --with-page arg for Browser actions. Fixes #1795
@jwoertink jwoertink merged commit 2e92959 into main Sep 1, 2023
4 of 5 checks passed
@jwoertink jwoertink deleted the issues/1795 branch September 1, 2023 17:50
@jwoertink jwoertink mentioned this pull request Sep 21, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add a --with-page flag to gen.action.browser task
1 participant
@jwoertink