Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing compilation error on Windows #1929

Merged
merged 1 commit into from
Nov 3, 2024
Merged

Fixing compilation error on Windows #1929

merged 1 commit into from
Nov 3, 2024

Conversation

jwoertink
Copy link
Member

Purpose

Fixes #1928

Description

This call to pretty_inspect seems to cause a compilation error on Avram. The error message doesn't seem to change between having it and not, so I'm just removing it.

Checklist

  • - An issue already exists detailing the issue/or feature request that this PR fixes
  • - All specs are formatted with crystal tool format spec src
  • - Inline documentation has been added and/or updated
  • - Lucky builds on docker with ./script/setup
  • - All builds and specs pass on docker with ./script/test

@jwoertink
Removing pretty_inspect since it doesn't seem to add any additional i…
acaca91 
…nformation to the error and it currently causes compilation errors on Windows. Fixes #1928
@jwoertink jwoertink merged commit 5607fe6 into main Nov 3, 2024
7 checks passed
@jwoertink jwoertink deleted the issues/1928 branch November 3, 2024 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

This call to pretty_inspect causes Avram to not compile on Windows
1 participant
@jwoertink