Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename modules with misspelled names #827

Merged
merged 1 commit into from
Jun 24, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,8 @@
### Changes since v0.15

- `Lucky::Exposeable` has been renamed to `Lucky::Exposable`
- `Lucky::Routeable` has been renamed to `Lucky::Routable`

### v0.15 (2019-06-12)

- Removed `Lucky::Action::Status`. Use Crystal's `HTTP::Status` enum. [#769](https://github.com/luckyframework/lucky/pull/769)
Expand Down
4 changes: 2 additions & 2 deletions src/lucky/action.cr
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,8 @@ abstract class Lucky::Action

include Lucky::ActionDelegates
include Lucky::RequestTypeHelpers
include Lucky::Exposeable
include Lucky::Routeable
include Lucky::Exposable
include Lucky::Routable
include Lucky::Renderable
include Lucky::ParamHelpers
include Lucky::ActionCallbacks
Expand Down
2 changes: 1 addition & 1 deletion src/lucky/error_action.cr
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ abstract class Lucky::ErrorAction
include Lucky::Renderable
include Lucky::Redirectable
include Lucky::RequestTypeHelpers
include Lucky::Exposeable
include Lucky::Exposable

getter context

Expand Down
2 changes: 1 addition & 1 deletion src/lucky/exposeable.cr → src/lucky/exposable.cr
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
module Lucky::Exposeable
module Lucky::Exposable
macro included
EXPOSURES = [] of Symbol

Expand Down
2 changes: 1 addition & 1 deletion src/lucky/routeable.cr → src/lucky/routable.cr
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# Methods for routing HTTP requests and their parameters to actions.
module Lucky::Routeable
module Lucky::Routable
macro fallback
Lucky::RouteNotFoundHandler.fallback_action = {{ @type.name.id }}
setup_call_method({{ yield }})
Expand Down
2 changes: 1 addition & 1 deletion src/lucky/route_not_found_handler.cr
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
#
# This handler should be used after the `Lucky::RouteHandler`.
#
# See `Lucky::Routeable.fallback` for implementing the `fallback_action`.
# See `Lucky::Routable.fallback` for implementing the `fallback_action`.
class Lucky::RouteNotFoundHandler
include HTTP::Handler
class_property fallback_action : Lucky::Action.class | Nil
Expand Down