Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accept every integer type on the #pluralize method #890

Merged
merged 1 commit into from
Sep 4, 2019
Merged

Accept every integer type on the #pluralize method #890

merged 1 commit into from
Sep 4, 2019

Conversation

vinibrsl
Copy link
Contributor

@vinibrsl vinibrsl commented Sep 4, 2019

Purpose

This PR makes the #pluralize method to accept every integer subtype (BigInt, Int16, Int32, Int64, Int8, UInt16, UInt32, UInt64, UInt8).

Description

This changes the #pluralize method signature to Int.

Checklist

  • - An issue already exists detailing the issue/or feature request that this PR fixes
  • - All specs are formatted with crystal tool format spec src
  • - Inline documentation has been added and/or updated
  • - Lucky builds on docker with ./script/setup
  • - All builds and specs pass on docker with ./script/test

Closes #887

@vinibrsl vinibrsl changed the title Replace Int32 type with Int on #pluralize signature Accept every integer type on the #pluralize method Sep 4, 2019
jwoertink
jwoertink approved these changes Sep 4, 2019
View reviewed changes
Copy link
Member

@jwoertink jwoertink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet! Thanks for taking care of that.

@paulcsmith
Copy link
Member

Looks great! Thanks for tackling this

@paulcsmith paulcsmith merged commit d05516d into luckyframework:master Sep 4, 2019
@vinibrsl vinibrsl deleted the accept-int-pluralize branch September 4, 2019 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jwoertink jwoertink jwoertink approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Pluralize doesn't take Int64
3 participants
@vinibrsl @paulcsmith @jwoertink