Tone down the watcher error #968
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It took way too much attention away from the real error. Make it subtle and less wordy.
paulcsmith
commented
Nov 15, 2019
| @@ -166,15 +166,16 @@ module LuckySentry | |||
| end | |||
|
|
|||
| private def print_error_message | |||
| puts "There was a problem compiling. Watching for fixes...".colorize(:red) | |||
There was a problem hiding this comment.
Yeah I know. There's a giant compiler error 🤣
| if successful_compilations.zero? | ||
| puts <<-ERROR | ||
|
|
||
| Try this... | ||
| #{"---".colorize.dim} |
There was a problem hiding this comment.
Divider so it is separate from the Crystal compile error
| Feeling stuck? Try this... | ||
|
|
||
| ▸ Run setup: #{"script/setup".colorize.bold} | ||
| ▸ Reinstall shards: #{"rm -rf lib bin && shards install".colorize.bold} |
There was a problem hiding this comment.
Sometimes cached binaries and shards cause issues during Crystal upgrades
|
Here's what it used to look like
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It took way too much attention away from the real error.
Make it subtle and less wordy.