Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sorting the type declarations from needs so the nillable ones are las… #993

Merged
merged 4 commits into from
Dec 23, 2019
Merged

Sorting the type declarations from needs so the nillable ones are las… #993

merged 4 commits into from
Dec 23, 2019

Commits on Dec 23, 2019

  1. Sorting the type declarations from needs so the nillable ones are las… 

    …t in the constructor. Fixes #992
    @jwoertink
    jwoertink committed Dec 23, 2019
    Configuration menu
    Copy the full SHA
    d85e398 View commit details
    Browse the repository at this point in the history

  2. Account for when a needs has a default value that isn't nilable. 

    Moved the test spec to assignable where other needs are tested
    @jwoertink
    jwoertink committed Dec 23, 2019
    Configuration menu
    Copy the full SHA
    05b459a View commit details
    Browse the repository at this point in the history

  3. make sure that type declarations with a default of false and nil are … 

    …also moved to the back of the list
    @jwoertink
    jwoertink committed Dec 23, 2019
    Configuration menu
    Copy the full SHA
    c90ddcc View commit details
    Browse the repository at this point in the history

  4. added a few more needs just to be sure we're covering edge cases. I h… 

    …ope that's all of them
    @jwoertink
    jwoertink committed Dec 23, 2019
    Configuration menu
    Copy the full SHA
    de4242f View commit details
    Browse the repository at this point in the history