-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
When create a new lucky app, the postgres_data volume never work as expected. #798
Comments
BTW: to verify the volume
because db data never save to a referenceable volume ... when you |
Sure, you can send a PR for that fix. I think that makes sense 👍 |
zw963
added a commit
to zw963/lucky_cli
that referenced
this issue
Apr 23, 2023
1. use short volume bind syntax. 2. fix postgres volume issue, check luckyframework#798. 3. Add POSTGRES_DB env for clarify. 4. Add crystal build cache into volume for better performance.
zw963
added a commit
to zw963/lucky_cli
that referenced
this issue
Apr 23, 2023
1. use short volume bind syntax. 2. fix postgres volume issue. check luckyframework#798. 3. Add POSTGRES_DB env for clarify, check luckyframework/lucky#1791 (reply in thread) 4. Add crystal build cache into volume for better performance.
zw963
added a commit
to zw963/lucky_cli
that referenced
this issue
Apr 23, 2023
1. use short volume bind syntax. 2. fix postgres volume issue. check luckyframework#798 3. Add POSTGRES_DB env for clarify. check luckyframework/lucky#1791 4. Add crystal build cache into volume for better performance.
jwoertink
pushed a commit
that referenced
this issue
May 14, 2023
* Refine docker-compose.yml: 1. use short volume bind syntax. 2. fix postgres volume issue. check #798 3. Add POSTGRES_DB env for clarify. check luckyframework/lucky#1791 4. Add crystal build cache into volume for better performance. * Refine dev_entrypoint.sh * Add shards cache as volume * Add app/bin into volume for isolation the binaries created from container with locals.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When create a new lucky app, will create a docker-compose.yml like this
But above code never work, because postgres offical Dockerfile create a new volume early from /var/lib/postgresql/data, which cause latter bind mount from /var/lib/postgresql always a empty data folder, because data folder below /var/lib/postgresql is a mounted volume.
if check docker inspect, you can see two mount point.
The fix is quite simple, just change
target: /var/lib/postgresql
intotarget: /var/lib/postgresql/data
.I give some advice in discuss here too, but, i guess someone miss this question. 😄
If consider accept contribute on those changes, i will create a PR for fix this.
The text was updated successfully, but these errors were encountered: