Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Memoize current_user in actions #508

Merged
merged 2 commits into from
Feb 19, 2023
Merged

Memoize current_user in actions #508

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b8872d8
Memoize current_user in BrowserAction
paulcsmith Apr 25, 2020
4011f85
Clarify what memoize is doing
paulcsmith Jun 9, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/api_authentication_app_skeleton/src/actions/mixins/api/auth/helpers.cr
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
module Api::Auth::Helpers
def current_user? : User?
# The 'memoize' macro makes sure only one query is issued to find the user
memoize def current_user? : User?
auth_token.try do |value|
user_from_auth_token(value)
end
Expand Down
3 changes: 2 additions & 1 deletion src/browser_app_skeleton/src/actions/browser_action.cr.ecr
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,8 @@ abstract class BrowserAction < Lucky::Action
expose current_user

# This method tells Authentic how to find the current user
private def find_current_user(id) : User?
# The 'memoize' macro makes sure only one query is issued to find the user
private memoize def find_current_user(id) : User?
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can just set this type to User. If it's nil, it just won't memoize. I saw you opened the issue already for that, but until we have that in, this could be a small win.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure I understand. The User can be nil so I can't change the return type to not have nil.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The memoize right now doesn't allow you to specify a union like User? https://github.com/luckyframework/lucky/blob/master/src/lucky/memoizable.cr#L21 so this should throw a compile time error.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah this does throw an error so I opened the issue to add support. I’m not sure how we’d get a quick win by setting it to User because that also won’t compile. I am quite tired so maybe just being dense haha

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that memoize supports taking args and having a nil value, I think this is fine. 😄

UserQuery.new.id(id).first?
end
<%- end -%>
Expand Down