Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make users email column case insensitive #657

Merged
merged 1 commit into from
Jul 11, 2021

Conversation

matthewmcgarvey
Copy link
Member

Fixes luckyframework/authentic#9
Fixes #597

Before this change, if a user created an account with Foo@example.com and then tried to sign in with foo@example.com it wouldn't have worked. They could also have made another account with different cases in the email. Now that's not possible.

Copy link
Member

@jwoertink jwoertink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

Copy link
Member

@stephendolan stephendolan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a really great change!

@matthewmcgarvey matthewmcgarvey merged commit 12f0809 into master Jul 11, 2021
@matthewmcgarvey matthewmcgarvey deleted the case-insensitive-email branch July 11, 2021 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update users migration template to make email column case insensitive Emails should be case insensitive
3 participants