Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comment out unconfigured RequestIdHandler #739

Merged
merged 1 commit into from
Mar 5, 2022

Conversation

grepsedawk
Copy link
Contributor

A new lucky app results in ameba errors due to this block's contents
being commented out. By commenting out the whole block, we still
provide the user useful configuration information without leaving an
empty block

A new lucky app results in ameba errors due to this block's contents
being commented out. By commenting out the whole block, we still
provide the user useful configuration information without leaving an
empty block
Copy link
Member

@jwoertink jwoertink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good 👍 Thanks!

@jwoertink jwoertink merged commit 0b5b8fb into luckyframework:main Mar 5, 2022
@grepsedawk grepsedawk deleted the patch-1 branch March 5, 2022 22:22
grepsedawk added a commit to grepsedawk/horseshoe that referenced this pull request Mar 5, 2022
Otherwise the lucky_cli generation might not match actual lucky code

Also, delete a few lines from the lucky template to ensure ameba passes

Only until luckyframework/lucky_cli#739 is
released
grepsedawk added a commit to grepsedawk/horseshoe that referenced this pull request Mar 5, 2022
Otherwise the lucky_cli generation might not match actual lucky code

Also, delete a few lines from the lucky template to ensure ameba passes

Only until luckyframework/lucky_cli#739 is
released
grepsedawk added a commit to grepsedawk/template that referenced this pull request Mar 10, 2022
Otherwise the lucky_cli generation might not match actual lucky code

Also, delete a few lines from the lucky template to ensure ameba passes

Only until luckyframework/lucky_cli#739 is
released
grepsedawk added a commit to grepsedawk/template that referenced this pull request Mar 10, 2022
Otherwise the lucky_cli generation might not match actual lucky code

Also, delete a few lines from the lucky template to ensure ameba passes

Only until luckyframework/lucky_cli#739 is
released
grepsedawk added a commit to grepsedawk/template that referenced this pull request Mar 10, 2022
Otherwise the lucky_cli generation might not match actual lucky code

Also, delete a few lines from the lucky template to ensure ameba passes

Only until luckyframework/lucky_cli#739 is
released
grepsedawk added a commit to grepsedawk/template that referenced this pull request Mar 10, 2022
Otherwise the lucky_cli generation might not match actual lucky code

Also, delete a few lines from the lucky template to ensure ameba passes

Only until luckyframework/lucky_cli#739 is
released
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants