Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: dockerfile dev fixes (gunzip, bump lucky-cli) #787

Merged

Conversation

stan-slas
Copy link
Contributor

Hello LuckyCLI Team,

I am new to Crystal world and wanted to give a try without installing various dependencies on my host (like configuring postgresql 🙈 ), but current dev dockerfile generated by Lucky CLI had some issues:

🐳 step Command Error Comment
STEP2 apt-get install -y wget gzip Unable to locate package gunzip gunzip is already installed from the base image crystal:1.4.1. If it was missing I guess gzip is the package to install to get gunzip, gzip and zcat
STEP8 git checkout v0.30.0 N/A Cf #781, I was expecting to get the latest release. I just did another hardcoded bump for now

How it has been tested ?
After this PR I was able to build and run the container with various lucky cli

  • lucky --version => 1.0.0-rc1
  • lucky init working too

Now I have to try the framework 😃

PS: maybe worth it mentioning in the doc https://luckyframework.org/guides/getting-started/installing that docker and compose templates are available ? That's a great feature !

@jkthorne
Copy link
Contributor

I am currently working through my docker files and made these changes locally. This is a great update.

Copy link
Member

@jwoertink jwoertink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thanks so much for fixing this. Welcome to Lucky 🎉

@stan-slas
Copy link
Contributor Author

Regarding the CI I got

 API token is invalid, please generate a new one response: Failed to log in with provided credentials. (SecTester::Error)

at each SecTester test.

I am wondering if the

BRIGHT_TOKEN: ${{ secrets.BRIGHT_API_KEY }}
BRIGHT_PROJECT_ID: ${{ secrets.BRIGHT_PROJECT_ID }}

are still valid ? 🤔

@jwoertink
Copy link
Member

Yeah, I might just have to generate a new one, it looks like.

@bararchy do these expire normally? I haven't changed anything, so I'm not sure if this is something I have to just keep updated from time to time?

@jwoertink jwoertink merged commit 81faf85 into luckyframework:main Feb 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants