Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to LuckyTemplate - Part 1 of ... #804

Merged
merged 15 commits into from
Jun 11, 2023
Merged

Migrate to LuckyTemplate - Part 1 of ... #804

merged 15 commits into from
Jun 11, 2023

Conversation

mdwagner
Copy link
Contributor

@mdwagner mdwagner commented Jun 10, 2023

  • Changes app_with_sec_tester to use lucky_template
  • Changes api_authentication_app_skeleton to use lucky_template
  • Updates CI workflow to specifically run each expected matrix build (at least for now, it makes it more clear what things we expect to run. eventually, I hope we can just use matrix vars normally)
  • Didn't add specs for switching to lucky_template, as I plan to add them after subsequent PR. I expect there might be a small refactor
  • Updated Weekly CI builds to include edge + nightly, and removed those as requirements on PRs

@mdwagner mdwagner self-assigned this Jun 10, 2023
@jwoertink
Copy link
Member

Sorry, I just merged #800 😅 so it may be a bit wonky.

@mdwagner
Copy link
Contributor Author

@jwoertink are these failures warranted? Also, for the nightly build, what if we had that run on a cron for main (maybe once per week)?

@mdwagner mdwagner changed the title Migrate to LuckyTemplate Migrate to LuckyTemplate - Part 1 of ... Jun 11, 2023
@mdwagner mdwagner marked this pull request as ready for review June 11, 2023 13:56
@jwoertink
Copy link
Member

The Ameba one will hopefully be fixed when they do a new release. I'm not sure why SecTester is failing. I think we just need to release a new version of SecTester and make sure that's updated, but I wouldn't worry about it on this PR.

Also, for the nightly, moving to a weekly cron sounds good. It would be nice to have them checked on each PR, but since the Crystal nightlies don't actually build new releases nightly, I guess it doesn't make a ton of sense how we have it setup now.

Copy link
Member

@jwoertink jwoertink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! This CLI will look completely different when these are all done 🥳

@mdwagner
Copy link
Contributor Author

@jwoertink
So, I realized that there already was a Weekly cron CI, and just updated that.

Also, I think having edge and nightly builds on main actually makes more sense, since they are more likely to break, and I would think we don't want contributions to have such a high bar, unless the expectation is something like "this project only exists off nightly/latest", right?

I think PRs should be pretty consistent when run, and instead let advanced contributors deal with upcoming issues as they see fit.

@mdwagner mdwagner merged commit 720d86b into main Jun 11, 2023
@mdwagner mdwagner deleted the feat/lucky-template branch June 11, 2023 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants