-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate to LuckyTemplate - Part 1 of ... #804
Conversation
feat!: app_with_sec_tester changed ecr paths back
Sorry, I just merged #800 😅 so it may be a bit wonky. |
feat!: app_with_sec_tester changed ecr paths back
…_cli into feat/lucky-template
@jwoertink are these failures warranted? Also, for the nightly build, what if we had that run on a cron for main (maybe once per week)? |
The Ameba one will hopefully be fixed when they do a new release. I'm not sure why SecTester is failing. I think we just need to release a new version of SecTester and make sure that's updated, but I wouldn't worry about it on this PR. Also, for the nightly, moving to a weekly cron sounds good. It would be nice to have them checked on each PR, but since the Crystal nightlies don't actually build new releases nightly, I guess it doesn't make a ton of sense how we have it setup now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! This CLI will look completely different when these are all done 🥳
@jwoertink Also, I think having edge and nightly builds on main actually makes more sense, since they are more likely to break, and I would think we don't want contributions to have such a high bar, unless the expectation is something like "this project only exists off nightly/latest", right? I think PRs should be pretty consistent when run, and instead let advanced contributors deal with upcoming issues as they see fit. |
Updates CI workflow to specifically run each expected matrix build (at least for now, it makes it more clear what things we expect to run. eventually, I hope we can just use matrix vars normally)