Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use webdrivers.cr to auto-install the correct version #74

Closed
paulcsmith opened this issue Apr 29, 2020 · 2 comments · Fixed by #80
Closed

Use webdrivers.cr to auto-install the correct version #74

paulcsmith opened this issue Apr 29, 2020 · 2 comments · Fixed by #80

Comments

@paulcsmith
Copy link
Member

https://github.com/matthewmcgarvey/webdrivers.cr

See https://gitter.im/luckyframework/Lobby?at=5ea98b753d58de7a38e36686

In lucky_flow, you'd update

driver_path = LuckyFlow.settings.chromedriver_path ||
with Webdrivers::Chromedriver.install

We should probably make this configurable via Habitat. There may be people that do not want this, or environments where they want to use a preinstalled/vendored version

@matthewmcgarvey
Copy link
Member

I'm not sure if it should go in this library our be included in the generated app. I'm considering that capybara does not include the webdrivers gem, but it has to be added to the app.

The generated app would have LuckyFlow configured like:

require "webdrivers"

LuckyFlow.configure do |settings|
  settings.chromedriver_path = Webdrivers::Chromedriver.install
end

@paulcsmith
Copy link
Member Author

I think I'd prefer it to be in LuckyFlow so it "just works" out of the box. There are a lot of people that don't know about webdrivers and there's lives would be a lot happier with it I think 😂

But I think some people may not want it so as long as we have an option to disable it/provide your own path then I think it is probably the best of both worlds.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants