Use webdrivers.cr for managing drivers #80
Conversation
| @@ -15,7 +16,7 @@ class LuckyFlow | |||
| setting base_uri : String | |||
| setting retry_delay : Time::Span = 10.milliseconds | |||
| setting stop_retrying_after : Time::Span = 1.second | |||
| setting chromedriver_path : String = LuckyFlow.default_driver_path | |||
| setting chromedriver_path : String? | |||
There was a problem hiding this comment.
@paulcsmith This might be a bug with Habitat or a known limitation but when I had the installation here and caused a failure, it failed with a message about recursion while setting class variables.
There was a problem hiding this comment.
Hmm could you open an issue in Habitat? I don’t think I’ve seen that before and am not sure I understand what caused it but it seems like we should support it or at least raise a better error :D
There was a problem hiding this comment.
Here's the issue luckyframework/habitat#46
| @@ -15,7 +16,7 @@ class LuckyFlow | |||
| setting base_uri : String | |||
| setting retry_delay : Time::Span = 10.milliseconds | |||
| setting stop_retrying_after : Time::Span = 1.second | |||
| setting chromedriver_path : String = LuckyFlow.default_driver_path | |||
| setting chromedriver_path : String? | |||
There was a problem hiding this comment.
Hmm could you open an issue in Habitat? I don’t think I’ve seen that before and am not sure I understand what caused it but it seems like we should support it or at least raise a better error :D
Fixes #74
Fixes #54
Summary
Rather than depending on the user to have chromedriver installed or including a vendored version with the library, use webdrivers.cr to install and manage the drivers. After switching to this library, we will now have all the infrastructure in place to begin offering testing in other browsers like Firefox.
Considerations
This library will make http calls in order to find the latest drivers and install them. There are potential failure points that come with it, especially as this library is not as battle-tested as the ruby version.
By default it installs drivers at
~/.webdriversbut it can be configured.