Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add keyboard shortcut to focus search 🙏 #490

Closed
matthewmcgarvey opened this issue Nov 13, 2020 · 5 comments · Fixed by #889
Closed

Add keyboard shortcut to focus search 🙏 #490

matthewmcgarvey opened this issue Nov 13, 2020 · 5 comments · Fixed by #889

Comments

@matthewmcgarvey
Copy link
Member

I'd love it if / would focus the search input!

@matthewmcgarvey matthewmcgarvey changed the title Add keyboard shortcut to focus search 🥺 Add keyboard shortcut to focus search 🙏 Nov 13, 2020
@stephendolan
Copy link
Member

@matthewmcgarvey Agreed that this would be fantastic. I've spent some time digging in recently, actually.

Here's an issue on their repo discussing:
algolia/docsearch#973

It seems like we'll have this in the next version (3.0), at which point we can bump the include in layout_head.cr and have it available.

I briefly looked into bumping us to the v3.0.0 alpha to test, but it seems as though the jsdeliver and unpkg links don't have minified dist files yet.

@jwoertink
Copy link
Member

Just to make it easier to check back, it looks like we're just waiting on this to be available

https://cdn.jsdelivr.net/npm/docsearch.js@3/dist/cdn/docsearch.min.js

@jwoertink
Copy link
Member

not sure if this just changed or not, but I just hit tab and it focuses the search...

@matthewmcgarvey
Copy link
Member Author

I hope that algolia didn't take over tab. I thought that was an accessibility feature to cycle through available targets

@stephendolan
Copy link
Member

Yeah, Tab isn't doing anything for me except the standard browser tabbing from the homepage!

jwoertink added a commit that referenced this issue Jan 13, 2022
* upgrading Algolia search to latest version. Fixes #443. Fixes #490

* Style the search box a little
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants