-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ws command line interface. #23
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few small suggestions, but this looks great! Thank you.
Co-authored-by: Jeremy Woertink <jeremywoertink@gmail.com>
Co-authored-by: Jeremy Woertink <jeremywoertink@gmail.com>
Co-authored-by: Jeremy Woertink <jeremywoertink@gmail.com>
Hi, @jwoertink , i try improve banner usage for ws again, please help on check english. : ) And bump a new version to fix some error when pacakge and avoid flush ours discussion. One more question: I found when i add following code into shard.yml, the diff --git a/shard.yml b/shard.yml
index 014b24d..b7dd167 100644
--- a/shard.yml
+++ b/shard.yml
@@ -5,6 +5,10 @@ authors:
- Paul Smith <paulcsmith0218@gmail.com>
- Flinn Mueller <theflinnster@gmail.com>
+targets:
+ ws:
+ main: src/ws.cr
+
crystal: ">= 1.4.0" This is so wired, because i want to remove this diff because i thought Thank you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've added a few new comments for the new updates.
Co-authored-by: Jeremy Woertink <jeremywoertink@gmail.com>
I test the mac version ws precompile binary, it works. For those tag, because i create tag v0.3.1 and v0.3.2 on my fork, should i remove those tag before merge? |
I consider if the name of I don't know if there is a command told |
I searched apt and didn't see any |
I guess the tag should never be merged in a PR. And for the tag, it means when maintainer create a new valid version tag like this: v0.0.3 which start with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks good to me 👍 I guess we can just merge this in and give it a shot. Thanks for putting this together!
This commit including following changes:
src/ws.cr
, it used to buildws
command, it not required by default.Code probably still optimizing, but it works!