Luuk/orbiit surt font #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| text-align: left; | ||
| } | ||
|
|
||
| * { | ||
| color: inherit; | ||
| } | ||
|
|
||
| @font-face { |
There was a problem hiding this comment.
I did this with Poppins originally, but Next.js gets angry if you use @import for fonts. Some vulnerability or something. Hence be building that <Fonts /> component. A bit more annoying becaue you have to add both DesignProvider and Fonts, but the error went away.
There was a problem hiding this comment.
Oh interesting, I haven't seen it throw that yet, but will try it by updating Fonts
|
I think it's a warning still, not an error, it still builds. But it showed
up big and red in my console...
Jonas
*~*
Jonas Haefele
Founder of slow.works
Coaching and consulting in mindful and sustainable tech.
In order to focus on my work, I check emails twice a day and aim to respond
the next day.
In emergencies, please call +44 742 906 6868
*~*
…On Mon, 28 Sep 2020 at 14:26, luckylwk ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In src/components/DesignProvider/DesignProvider.js
<#62 (comment)>
:
> text-align: left;
}
* {
color: inherit;
}
+
+ @font-face {
Oh interesting, I haven't seen it throw that yet, but will try it by
updating Fonts
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#62 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAIZO6E4VVJHI7MV7YUDB43SICFJTANCNFSM4R4K3EEA>
.
|
|
I can do a separate PR to harmonise font sizes again and check with the designs. Poppins and Surt render in different sizes. |
Comment on lines
+46
to
+51
| "node-forge": "^0.10.0", | ||
| "node-fetch": "^2.6.1", | ||
| "yargs-parser": "^13.1.2", | ||
| "http-proxy": "^1.18.1", | ||
| "dot-prop": "^4.2.1", | ||
| "serialize-javascript": "^3.1.0" |
There was a problem hiding this comment.
what do all of these do?
There was a problem hiding this comment.
I keep getting github dependabot notifications
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.