Bug fix: Use safe rename which works across filesystems when writing checkpoints #2225
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On some systems, the temp directory and model output directory live on different filesystems. When we write checkpoint to temp directory, then
os.replace
oros.rename
to the destination, we get:This PR adds
safe_move_file
, which attempts toos.replace()
, and does an atomicshutil.copyfile
if we get the cross-filesystem error (errno.EXDEV == 18).