Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding configs used in benchmarking #2263

Merged
merged 6 commits into from
Jul 14, 2022
Merged

adding configs used in benchmarking #2263

merged 6 commits into from
Jul 14, 2022

Conversation

abidwael
Copy link
Contributor

Contains configs that are used in benchmarking. Note that text features will contain trainable: true parameter.

@abidwael abidwael requested a review from dantreiman July 12, 2022 19:20
@github-actions
Copy link

github-actions bot commented Jul 12, 2022

Unit Test Results

       6 files  +    1         6 suites  +1   2h 22m 10s ⏱️ + 21m 44s
2 912 tests  -   17  2 866 ✔️  - 17    46 💤 ±  0  0 ±0 
8 736 runs  +120  8 594 ✔️ +97  142 💤 +23  0 ±0 

Results for commit f551b47. ± Comparison against base commit 9c58d5e.

♻️ This comment has been updated with latest results.

@abidwael abidwael changed the title addings configs used in benchmarking adding configs used in benchmarking Jul 13, 2022
Copy link
Contributor

@dantreiman dantreiman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, two minor comments

ludwig/benchmarking/configs/allstate_claims_severity.yaml Outdated Show resolved Hide resolved
ludwig/benchmarking/configs/yelp_reviews.yaml Outdated Show resolved Hide resolved
@abidwael abidwael merged commit a3cbcbb into master Jul 14, 2022
@abidwael abidwael deleted the benchmarking-configs branch July 14, 2022 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants