Fix: Don't skip saving the model if the save path already exists. #2264
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this change, the model is only saved the first time
save()
is called (at the end of the first round of evaluation).This is a bug that was introduced in #2027. This was not caught by any model loading unit tests like
tests/integration_tests/test_model_save_and_load.py
because the best saved weights are reloaded automatically at the end oftrain()
, so there's never a discrepancy between the model returned fromtrain()
and models loaded from disk.@jimthompson5802 will send a follow up PR that adds a test that catches this regression specifically.
Closes #2259