Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix error in postproc_predictions calculation in model.evaluate() #2304

Merged
merged 1 commit into from
Jul 25, 2022
Merged

Fix error in postproc_predictions calculation in model.evaluate() #2304

merged 1 commit into from
Jul 25, 2022

Conversation

arnavgarg1
Copy link
Contributor

Issue description: #2303

  1. We weren't passing in the backend before, which is something we should've done during the call to convert_predictions
  2. We want to check if values is either a Dask DataFrame or a Dask Series - in either case, we want to explicitly call compute.

@arnavgarg1 arnavgarg1 added the bug Something isn't working label Jul 22, 2022
@arnavgarg1 arnavgarg1 self-assigned this Jul 22, 2022
@arnavgarg1 arnavgarg1 linked an issue Jul 22, 2022 that may be closed by this pull request
Failedpostproc_predictions calculation in model.evaluate() #2303
Closed
@arnavgarg1 arnavgarg1 changed the title Passing backend and modifying check to include dask series Failedpostproc_predictions calculation in model.evaluate() Jul 22, 2022
@arnavgarg1 arnavgarg1 changed the title Failedpostproc_predictions calculation in model.evaluate() Failed postproc_predictions calculation in model.evaluate() Jul 22, 2022
@arnavgarg1 arnavgarg1 changed the title Failed postproc_predictions calculation in model.evaluate() Fix error in postproc_predictions calculation in model.evaluate() Jul 22, 2022
@arnavgarg1 arnavgarg1 marked this pull request as ready for review July 23, 2022 00:27
@github-actions
Copy link

Unit Test Results

       5 files  +       2         5 suites  +2   2h 1m 43s ⏱️ + 46m 37s
2 936 tests ±       0  2 887 ✔️ ±       0    49 💤 ±  0  0 ❌ ±0 
8 683 runs  +2 936  8 521 ✔️ +2 868  162 💤 +68  0 ❌ ±0 

Results for commit cd9e82f. ± Comparison against base commit 06594a5.

@arnavgarg1 arnavgarg1 merged commit 03628d7 into master Jul 25, 2022
@arnavgarg1 arnavgarg1 deleted the 2303-failedpostproc_predictions-calculation-in-modelevaluate branch July 25, 2022 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShreyaR ShreyaR ShreyaR approved these changes

@justinxzhao justinxzhao Awaiting requested review from justinxzhao justinxzhao is a code owner

@geoffreyangus geoffreyangus Awaiting requested review from geoffreyangus geoffreyangus is a code owner

Assignees

@arnavgarg1 arnavgarg1

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Failedpostproc_predictions calculation in model.evaluate()
2 participants
@arnavgarg1 @ShreyaR