Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes TensorDtype TypeError in Ray nightly #2320

Merged
merged 2 commits into from
Jul 27, 2022
Merged

Conversation

geoffreyangus
Copy link
Contributor

@geoffreyangus geoffreyangus commented Jul 27, 2022

This PR fixes the hanging unit tests in the py39 (Ray nightly) unit tests. The change here accounts for recent changes to the Ray interface for Tensor type casting (ray-project/ray#27031).

@github-actions
Copy link

Unit Test Results

       6 files  +    1         6 suites  +1   2h 37m 17s ⏱️ + 42m 22s
2 941 tests ±    0  2 892 ✔️ ±    0    49 💤 ±  0  0 ±0 
8 823 runs  +125  8 640 ✔️ +104  183 💤 +21  0 ±0 

Results for commit 2ca6ace. ± Comparison against base commit a2bce0e.

Copy link
Contributor

@arnavgarg1 arnavgarg1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

Copy link
Contributor

@ShreyaR ShreyaR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks again for looking into this! :D

@geoffreyangus geoffreyangus marked this pull request as ready for review July 27, 2022 21:46
@geoffreyangus geoffreyangus merged commit 940141e into master Jul 27, 2022
@geoffreyangus geoffreyangus deleted the fix-cast-tensor-dtype branch July 27, 2022 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants