Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrap read of cached training set metadata in try/except for robustness #2373

Merged
merged 1 commit into from
Aug 11, 2022

Conversation

jeffreyftang
Copy link
Collaborator

In practice the read may sometimes fail even when the previous existence check passes, although whether this is due to a race condition or some quirk of the underlying filesystem isn't fully understood.

Converting an errored read into a cache miss seems reasonable and more robust behavior.

@github-actions
Copy link

Unit Test Results

       6 files  ±0         6 suites  ±0   2h 40m 2s ⏱️ - 3m 47s
2 966 tests ±0  2 917 ✔️ ±0    49 💤 ±0  0 ±0 
8 898 runs  ±0  8 715 ✔️ ±0  183 💤 ±0  0 ±0 

Results for commit 3ffc7ed. ± Comparison against base commit 6a9569a.

Copy link
Contributor

@justinxzhao justinxzhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like a reasonable change to me!

@jeffreyftang jeffreyftang merged commit d0c8f61 into master Aug 11, 2022
@jeffreyftang jeffreyftang deleted the cacheerr branch August 11, 2022 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants