Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Print final training report as tabulated text. #2383

Merged
merged 1 commit into from
Aug 16, 2022
Merged

Conversation

justinxzhao
Copy link
Contributor

Before:

╒═════════════════╕
│ TRAINING REPORT │
╘═════════════════╛

Best validation model step: 50, epoch: 10
Best validation model loss on validation set combined: 0.6572936773300171
Best validation model loss on test set combined: 0.5243139266967773

After:

╒═════════════════╕
│ TRAINING REPORT │
╘═════════════════╛

╒══════════════════════════════╤════════════════════╕
│ Validation feature           │ combined           │
├──────────────────────────────┼────────────────────┤
│ Validation metric            │ loss               │
├──────────────────────────────┼────────────────────┤
│ Best model step              │ 50                 │
├──────────────────────────────┼────────────────────┤
│ Best model epoch             │ 10                 │
├──────────────────────────────┼────────────────────┤
│ Best model's validation loss │ 0.6572936773300171 │
├──────────────────────────────┼────────────────────┤
│ Best model's test loss       │ 0.5243139266967773 │
╘══════════════════════════════╧════════════════════╛

@github-actions
Copy link

github-actions bot commented Aug 15, 2022

Unit Test Results

       6 files  ±0         6 suites  ±0   2h 39m 34s ⏱️ + 2m 31s
2 966 tests ±0  2 914 ✔️ ±0    52 💤 ±0  0 ±0 
8 898 runs  ±0  8 706 ✔️ ±0  192 💤 ±0  0 ±0 

Results for commit 027ce11. ± Comparison against base commit 1eff561.

♻️ This comment has been updated with latest results.

Copy link
Contributor

@arnavgarg1 arnavgarg1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice change, LGTM!

training_report.append(["Best model epoch", epoch_best_validation_metric + 1])
training_report.append(
[
f"Best model's validation {validation_metric}",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@justinxzhao Would it potentially make sense to mention that this is the combined loss?


training_report.append(
[
f"Best model's test {validation_metric}",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@justinxzhao Same as the previous comment

@justinxzhao justinxzhao merged commit dbea880 into master Aug 16, 2022
@justinxzhao justinxzhao deleted the training_report branch August 16, 2022 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants