Investigating test_resnet_block_layer intermittent test failure #2414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinxzhao
force-pushed
the
daniel/conv_test_failures
branch
from
2fc4212 to
bb816ce
Compare
dantreiman
force-pushed
the
daniel/conv_test_failures
branch
from
bb816ce to
c1bcc1a
Compare
|
Hi @dantreiman, what's your plan with this PR? It looks like tests are passing. Is it worth just merging this in? |
@justinxzhao Yeah, its ready. My suspicion was that this was failing due to OOM error, and I wasn't sure if this change was enough so I ran it a few times over the weekend. AFAICT I think its fine, added you as reviewer |
justinxzhao
approved these changes
Aug 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.