GBM: log intermediate progress #2421
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…et eval if available
for more information, see https://pre-commit.ci
justinxzhao
reviewed
Aug 26, 2022
| loss_name = params["metric"][0] | ||
| loss = evals_result[data_name][loss_name][-1] | ||
| metrics = {"Survived": {LOSS: loss}, COMBINED: {LOSS: loss}} | ||
| self.append_metrics(data_name, metrics, name_to_metrics_log[data_name], tables, progress_tracker) |
There was a problem hiding this comment.
Are/could we also log these metrics to stdout, similar to how ECD logs intermediate training metrics?
There was a problem hiding this comment.
Currently, LightGBM is already logging the loss to stdout. This PR just logs the loss, but eventually we might want to log intermediate metrics as well
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes GBM training iterative to log intermediate progress + add test set eval metrics if available