Fixed version transformation to accept user configs without ludwig_version #2424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgaddair
changed the title
tgaddair
changed the title
tgaddair
requested review from
dantreiman
and removed request for
connor-mccorm
dantreiman
approved these changes
Aug 29, 2022
| @@ -81,20 +81,17 @@ def wrap(fn: Callable[[Dict], Dict]): | |||
|
|
|||
| def upgrade_to_latest_version(config: Dict): | |||
| """Updates config from an older version of Ludwig to the current version. If config does not have a | |||
| "ludwig_version" key, no updates are applied. | |||
| "ludwig_version" key, all updates are applied. | |||
There was a problem hiding this comment.
In line 1361 of api.py LudwigModel.load() I added a similar condition: if no version in config, assume an old version. At this time I was thinking we should upgrade on load but error on init for old configs. On second thought, I agree this is better... and with this change the condition in api.py load() should be removed.
There was a problem hiding this comment.
Thanks! Removed code at line 1361.
Co-authored-by: Daniel Treiman <dan.treiman@gmail.com>
tgaddair
force-pushed
the
fix-early-stop
branch
from
5af69a7 to
e411f7f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this change, there is no opportunity to provide a deprecation period for user configs that lack the
ludwig_versionparam inserted as part of config rendering.Also adds additional tests around early stopping, automl, backwards compatibility, and version transformation ordering.