Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tests] Added more explicit lifecycle management to Ray clusters during tests #2447

Merged
merged 11 commits into from
Sep 5, 2022
Merged

[tests] Added more explicit lifecycle management to Ray clusters during tests #2447

merged 11 commits into from
Sep 5, 2022

Conversation

tgaddair
Copy link
Collaborator

@tgaddair tgaddair commented Sep 2, 2022

No description provided.

@github-actions
Copy link

github-actions bot commented Sep 2, 2022 •
edited
Loading

Unit Test Results

         6 files  +    1         6 suites  +1   2h 35m 44s ⏱️ + 19m 41s
  3 367 tests  -     1  3 289 ✔️ +  22    78 💤  -   1  0 ❌  - 22 
10 101 runs  +130  9 843 ✔️ +129  258 💤 +23  0 ❌  - 22 

Results for commit 1cc3491. ± Comparison against base commit 348f0bf.

♻️ This comment has been updated with latest results.

@tgaddair tgaddair changed the title Added checking to ensure ray initialized explicitly during tests [tests] Added more explicit lifecycle management to Ray clusters during tests Sep 5, 2022
@tgaddair tgaddair added the tests Issue with the tests label Sep 5, 2022
@tgaddair tgaddair marked this pull request as ready for review September 5, 2022 18:53
@tgaddair tgaddair requested a review from justinxzhao September 5, 2022 18:53
justinxzhao
justinxzhao approved these changes Sep 5, 2022
View reviewed changes
Copy link
Contributor

@justinxzhao justinxzhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like there's some really nice changes here as the CI is down to 31 minutes!

tests/integration_tests/test_preprocessing.py
"backend",
[
pytest.param("local", id="local"),
pytest.param("ray", id="ray", marks=pytest.mark.distributed),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool that you can add marks within as part of the parameterization like this.

@tgaddair tgaddair merged commit 42cf4f2 into master Sep 5, 2022
@tgaddair tgaddair deleted the explicit-ray-init branch September 5, 2022 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justinxzhao justinxzhao justinxzhao approved these changes

Assignees
No one assigned
Labels
tests Issue with the tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tgaddair @justinxzhao