Fixed support for distributed datasets in create_auto_config #2508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgaddair
changed the title
tgaddair
changed the title
justinxzhao
approved these changes
Sep 16, 2022
| @@ -1,9 +1,13 @@ | |||
| from abc import ABC, abstractmethod | |||
| from typing import List, Tuple | |||
|
|
|||
| import dask.dataframe as dd | |||
There was a problem hiding this comment.
This dask import should be ok since users using Ludwig automl are expected to pip install ludwig[distributed]. Is that right?
There was a problem hiding this comment.
Yeah, the automl library requires Ray and Dask to work.
tgaddair
added a commit
that referenced
this pull request
Sep 16, 2022
tgaddair
added a commit
that referenced
this pull request
Sep 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2499.
Related #2497.
Also changes exclusion logic to be less restrictive for index-looking fields.