Surfacing dataset statistics in hyperopt #2515
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinxzhao
approved these changes
Sep 16, 2022
arnavgarg1
added a commit
that referenced
this pull request
Sep 16, 2022
* surfacing dataset statistics in hyperopt * make datasets loaders a module
arnavgarg1
added a commit
that referenced
this pull request
Sep 16, 2022
…ropt (#2509) (#2518) * Add in-memory dataset size calculation to dataset statistics (#2509) * add in-memory dataset size calculation * reduce constraints on test * Fix failing tests by adding conditional checks before function call * merge into single tab, use memory formatter, fix conditional * clean up * make benchmarking a module * Surfacing dataset statistics in hyperopt (#2515) * surfacing dataset statistics in hyperopt * make datasets loaders a module
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up from 39ba541
This ensures that we can see dataset statistics for hyperopt and it also fixes the current issues with the dataloader on master