Updated schedule logic for placement groups for ray backend #2523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
…ludwig into updated-schedule-logic-for-pg
tgaddair
reviewed
Sep 18, 2022
|
@magdyksaleh I'm assuming you want this to be included in 0.6? In that case, you should add the |
|
Also, you should add a test to make sure this works as expected. |
for more information, see https://pre-commit.ci
ShreyaR
approved these changes
Sep 20, 2022
Added |
jeffreyftang
approved these changes
Sep 20, 2022
| @@ -812,17 +812,24 @@ def initialize(self): | |||
| # Disable placement groups on dask | |||
| dask.config.set(annotations={"ray_remote_args": {"placement_group": None}}) | |||
|
|
|||
| def generate_bundles(self, num_cpu): | |||
There was a problem hiding this comment.
Nit: prefix with underscore since this is not really meant to be used outside this package.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.