Extend test coverage for non-conventional booleans #2601
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinxzhao
approved these changes
Oct 5, 2022
Comment on lines
486
to
493
| warning_text = re.compile( | ||
| f"Binary feature {bin_feature[NAME]} has at least 1 unconventional boolean value:" | ||
| r" Cannot automatically map value '(>50K|<=50K)'" | ||
| " to a boolean and no `preprocessing.fallback_true_label` specified." | ||
| " We will now interpret <=50K as 1 and the other values as 0. If this is incorrect, please use the category" | ||
| " feature type or manually specify the true value with `preprocessing.fallback_true_label`." | ||
| ) | ||
| assert re.search(warning_text, caplog.text) is not None |
There was a problem hiding this comment.
I would recommend against checking on such a specific regex. If at any point someone changes the text of the warning, then they have to also update this test.
Maybe check against "*unconventional boolean value"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests for non-conventional binary feature that
fallback_true_labelis providedfallback_true_labelis providedCATEGORY