Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix assertions in training_determinism tests #2606

Merged
merged 1 commit into from
Oct 6, 2022
Merged

Fix assertions in training_determinism tests #2606

merged 1 commit into from
Oct 6, 2022

Conversation

arnavgarg1
Copy link
Contributor

@arnavgarg1 arnavgarg1 commented Oct 6, 2022 •
edited
Loading

These tests should be comparing the values from both of the runs, rather than to themselves.

abidwael
abidwael approved these changes Oct 6, 2022
View reviewed changes
Copy link
Contributor

@abidwael abidwael left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry about the typo. Thanks for the fix!

@github-actions
Copy link

github-actions bot commented Oct 6, 2022

Unit Test Results

         6 files  +    1           6 suites  +1   3h 39m 25s ⏱️ + 1h 3m 22s
  3 438 tests ±    0    3 364 ✔️ ±    0    74 💤 ±  0  0 ❌ ±0 
10 314 runs  +141  10 067 ✔️ +121  247 💤 +20  0 ❌ ±0 

Results for commit 11e7873. ± Comparison against base commit f6811c0.

@arnavgarg1 arnavgarg1 merged commit 9f26bf9 into master Oct 6, 2022
@arnavgarg1 arnavgarg1 deleted the test_training_determinism_typos branch October 6, 2022 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abidwael abidwael abidwael approved these changes

@justinxzhao justinxzhao justinxzhao approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@arnavgarg1 @justinxzhao @abidwael