bug: Set additionalProperties to True for preprocessing schemas.
#2620
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
connor-mccorm
approved these changes
Oct 10, 2022
Unit Test Results 6 files ±0 6 suites ±0 3h 34m 24s ⏱️ + 19m 28s For more details on these failures, see this check. Results for commit b180f04. ± Comparison against base commit c9a5c0a. ♻️ This comment has been updated with latest results. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@connor-mccorm I think that we shouldn't set
additionalPropertiestoFalselike this within the JSON schemas. At runtime, any properties that do not exist on the dataclasses will be excluded after load because of a flag we've set on theBaseMarshmallowConfigclass. But with this flag set directly on the schema you can get into weird situations with, amongst other things, upgrading and validating old configs.