accepting dictionary as input to benchmarking.benchmark
#2626
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
Unit Test Results 6 files ± 0 6 suites ±0 3h 36m 49s ⏱️ + 29m 19s For more details on these failures, see this check. Results for commit d549062. ± Comparison against base commit 03c39d4. ♻️ This comment has been updated with latest results. |
justinxzhao
reviewed
Oct 12, 2022
justinxzhao
reviewed
Oct 13, 2022
justinxzhao
approved these changes
Oct 13, 2022
justinxzhao
reviewed
Oct 13, 2022
justinxzhao
reviewed
Oct 13, 2022
added 2 commits
October 13, 2022 14:25
abidwael
force-pushed
the
benchmarking-accept-dict
branch
from
7c23283 to
d549062
Compare
justinxzhao
approved these changes
Oct 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing the following comments: