Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set internal only flags #2659

Merged
merged 8 commits into from
Oct 18, 2022
Merged

Set internal only flags #2659

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
2aa1bf2
Set internal only flags
connor-mccorm Oct 17, 2022
1939487
Update descriptions
connor-mccorm Oct 17, 2022
86187ce
Fixed dropout rate
connor-mccorm Oct 17, 2022
58cb7be
Fixed typ
connor-mccorm Oct 17, 2022
5cc1d7e
Add title to preprocessing
connor-mccorm Oct 17, 2022
d625450
Merge branch 'master' of https://github.com/ludwig-ai/ludwig into int…
connor-mccorm Oct 18, 2022
f941f2b
add titles
connor-mccorm Oct 18, 2022
8424f80
Removed additional properties constraint on defaults
connor-mccorm Oct 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ludwig/schema/encoders/sequence_encoders.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -735,7 +735,7 @@ class StackedRNNConfig(BaseEncoderConfig):

num_layers: int = schema_utils.PositiveInteger(
default=1,
description="the number of stacked recurrent layers.",
description="The number of stacked recurrent layers.",
parameter_metadata=ENCODER_METADATA["StackedRNN"]["num_layers"],
)

Expand Down Expand Up @@ -1234,7 +1234,7 @@ class StackedTransformerConfig(BaseEncoderConfig):

num_layers: int = schema_utils.PositiveInteger(
default=1,
description="the number of stacked recurrent layers.",
description="The number of transformer layers.",
parameter_metadata=ENCODER_METADATA["StackedTransformer"]["num_layers"],
)

Expand Down
6 changes: 5 additions & 1 deletion ludwig/schema/encoders/text_encoders.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -309,8 +309,10 @@ class MT5Config(BaseEncoderConfig):
parameter_metadata=ENCODER_METADATA["MT5Encoder"]["relative_attention_num_buckets"],
)

dropout_rate: float = schema_utils.NonNegativeFloat(
dropout_rate: float = schema_utils.FloatRange(
default=0.1,
min=0,
max=1,
description="The ratio for all dropout layers.",
parameter_metadata=ENCODER_METADATA["MT5Encoder"]["dropout_rate"],
)
Expand Down Expand Up @@ -2276,6 +2278,8 @@ class T5Config(BaseEncoderConfig):

dropout_rate: float = schema_utils.FloatRange(
default=0.1,
min=0,
max=1,
description="The ratio for all dropout layers.",
parameter_metadata=ENCODER_METADATA["T5Encoder"]["dropout_rate"],
)
Expand Down
1 change: 1 addition & 0 deletions ludwig/schema/features/preprocessing/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,7 @@ def _jsonschema_type_mapping():
return {
"type": "object",
"properties": props,
"title": "preprocessing_options",
connor-mccorm marked this conversation as resolved.
Show resolved Hide resolved
"additionalProperties": False,
}

Expand Down
2 changes: 1 addition & 1 deletion ludwig/schema/metadata/combiner_metadata.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,7 @@
other_information=None,
description_implications="The more layers that are specified the deeper and higher capacity the model "
"will be. This makes it possible to potentially achieve better performance when "
"a big anough amount of data is provided, but also makes the model more "
"a big enough amount of data is provided, but also makes the model more "
"computationally expensive and potentially more prone to overfitting.",
suggested_values=None,
suggested_values_reasoning="It is easier to define a stack of fully connected layers by just specifying "
Expand Down
48 changes: 24 additions & 24 deletions ludwig/schema/metadata/encoder_metadata.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -463,7 +463,7 @@
commonly_used=False,
expected_impact=ExpectedImpact.UNKNOWN,
literature_references=None,
internal_only=False,
internal_only=True,
),
},
"AutoTransformerEncoder": {
Expand Down Expand Up @@ -564,7 +564,7 @@
commonly_used=False,
expected_impact=ExpectedImpact.UNKNOWN,
literature_references=None,
internal_only=False,
internal_only=True,
),
},
"BERTEncoder": {
Expand Down Expand Up @@ -945,7 +945,7 @@
commonly_used=False,
expected_impact=ExpectedImpact.UNKNOWN,
literature_references=None,
internal_only=False,
internal_only=True,
),
},
"BagEmbedWeightedEncoder": {
Expand Down Expand Up @@ -1615,7 +1615,7 @@
commonly_used=False,
expected_impact=ExpectedImpact.UNKNOWN,
literature_references=None,
internal_only=False,
internal_only=True,
),
},
"CamemBERTEncoder": {
Expand Down Expand Up @@ -1994,7 +1994,7 @@
commonly_used=False,
expected_impact=ExpectedImpact.UNKNOWN,
literature_references=None,
internal_only=False,
internal_only=True,
),
},
"CategoricalEmbedEncoder": {
Expand Down Expand Up @@ -3378,7 +3378,7 @@
commonly_used=False,
expected_impact=ExpectedImpact.UNKNOWN,
literature_references=None,
internal_only=False,
internal_only=True,
),
},
"ELECTRAEncoder": {
Expand Down Expand Up @@ -3759,7 +3759,7 @@
commonly_used=False,
expected_impact=ExpectedImpact.UNKNOWN,
literature_references=None,
internal_only=False,
internal_only=True,
),
},
"FlauBERTEncoder": {
Expand Down Expand Up @@ -4260,7 +4260,7 @@
commonly_used=False,
expected_impact=ExpectedImpact.UNKNOWN,
literature_references=None,
internal_only=False,
internal_only=True,
),
},
"GPT2Encoder": {
Expand Down Expand Up @@ -4559,7 +4559,7 @@
commonly_used=False,
expected_impact=ExpectedImpact.UNKNOWN,
literature_references=None,
internal_only=False,
internal_only=True,
),
},
"GPTEncoder": {
Expand Down Expand Up @@ -4847,7 +4847,7 @@
commonly_used=False,
expected_impact=ExpectedImpact.UNKNOWN,
literature_references=None,
internal_only=False,
internal_only=True,
),
},
"H3Embed": {
Expand Down Expand Up @@ -5961,7 +5961,7 @@
commonly_used=False,
expected_impact=ExpectedImpact.UNKNOWN,
literature_references=None,
internal_only=False,
internal_only=True,
),
},
"MLPMixerEncoder": {
Expand Down Expand Up @@ -6528,7 +6528,7 @@
commonly_used=False,
expected_impact=ExpectedImpact.UNKNOWN,
literature_references=None,
internal_only=False,
internal_only=True,
),
},
"ParallelCNN": {
Expand Down Expand Up @@ -6947,7 +6947,7 @@
commonly_used=False,
expected_impact=ExpectedImpact.UNKNOWN,
literature_references=None,
internal_only=False,
internal_only=True,
),
"use_bias": ParameterMetadata(
ui_display_name="Use Bias",
Expand Down Expand Up @@ -7602,7 +7602,7 @@
commonly_used=False,
expected_impact=ExpectedImpact.UNKNOWN,
literature_references=None,
internal_only=False,
internal_only=True,
),
},
"SequenceEmbedEncoder": {
Expand Down Expand Up @@ -9225,7 +9225,7 @@
commonly_used=False,
expected_impact=ExpectedImpact.UNKNOWN,
literature_references=None,
internal_only=False,
internal_only=True,
),
"strides": ParameterMetadata(
ui_display_name="Stride",
Expand Down Expand Up @@ -9959,7 +9959,7 @@
commonly_used=False,
expected_impact=ExpectedImpact.UNKNOWN,
literature_references=None,
internal_only=False,
internal_only=True,
),
"state_size": ParameterMetadata(
ui_display_name=None,
Expand Down Expand Up @@ -10488,7 +10488,7 @@
commonly_used=False,
expected_impact=ExpectedImpact.UNKNOWN,
literature_references=None,
internal_only=False,
internal_only=True,
),
"stacked_layers": ParameterMetadata(
ui_display_name=None,
Expand Down Expand Up @@ -11031,7 +11031,7 @@
commonly_used=False,
expected_impact=ExpectedImpact.UNKNOWN,
literature_references=None,
internal_only=False,
internal_only=True,
),
"state_size": ParameterMetadata(
ui_display_name=None,
Expand Down Expand Up @@ -11531,7 +11531,7 @@
commonly_used=False,
expected_impact=ExpectedImpact.UNKNOWN,
literature_references=None,
internal_only=False,
internal_only=True,
),
"transformer_output_size": ParameterMetadata(
ui_display_name="Transformer Output Size",
Expand Down Expand Up @@ -11919,7 +11919,7 @@
commonly_used=False,
expected_impact=ExpectedImpact.UNKNOWN,
literature_references=None,
internal_only=False,
internal_only=True,
),
},
"TransformerXLEncoder": {
Expand Down Expand Up @@ -12409,7 +12409,7 @@
commonly_used=False,
expected_impact=ExpectedImpact.UNKNOWN,
literature_references=None,
internal_only=False,
internal_only=True,
),
},
"ViTEncoder": {
Expand Down Expand Up @@ -13253,7 +13253,7 @@
commonly_used=False,
expected_impact=ExpectedImpact.UNKNOWN,
literature_references=None,
internal_only=False,
internal_only=True,
),
},
"XLMRoBERTaEncoder": {
Expand Down Expand Up @@ -13441,7 +13441,7 @@
commonly_used=False,
expected_impact=ExpectedImpact.UNKNOWN,
literature_references=None,
internal_only=False,
internal_only=True,
),
},
"XLNetEncoder": {
Expand Down Expand Up @@ -13951,7 +13951,7 @@
commonly_used=False,
expected_impact=ExpectedImpact.UNKNOWN,
literature_references=None,
internal_only=False,
internal_only=True,
),
},
"encoder": {
Expand Down