Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check vocab size of category features, error out if only one category. Also adds error.py for custom error types. #2670

Merged
merged 2 commits into from
Oct 19, 2022
Merged

Check vocab size of category features, error out if only one category. Also adds error.py for custom error types. #2670

merged 2 commits into from
Oct 19, 2022

Conversation

dantreiman
Copy link
Contributor

No description provided.

@dantreiman dantreiman force-pushed the daniel/category_vocab_size_check branch from 24083e1 to 7f8f806 Compare October 18, 2022 22:45
@dantreiman dantreiman changed the title Check vocab size of category features, error out if only one category. Also adds custom error types to Ludwig Check vocab size of category features, error out if only one category. Also adds error.py for custom error types. Oct 18, 2022
@dantreiman dantreiman changed the title Check vocab size of category features, error out if only one category. Also adds error.py for custom error types. Check vocab size of category features, error out if only one category. Also adds error.py for custom error types. Oct 18, 2022
@github-actions
Copy link

github-actions bot commented Oct 18, 2022 •
edited
Loading

Unit Test Results

         4 files  +    1         4 suites  +1   2h 1m 21s ⏱️ + 49m 34s
  3 467 tests +157  3 390 ✔️ +139    77 💤 +18  0 ❌ ±0 
10 087 runs  +157  9 871 ✔️ +139  216 💤 +18  0 ❌ ±0 

Results for commit 4978fc8. ± Comparison against base commit b66ba5c.

♻️ This comment has been updated with latest results.

@dantreiman dantreiman requested review from tgaddair and removed request for tgaddair October 19, 2022 04:41
@dantreiman dantreiman force-pushed the daniel/category_vocab_size_check branch from 7f8f806 to 5c17422 Compare October 19, 2022 04:41
@dantreiman dantreiman force-pushed the daniel/category_vocab_size_check branch from 5c17422 to 4978fc8 Compare October 19, 2022 17:58
@dantreiman dantreiman merged commit 0fb2a4b into ludwig-ai:master Oct 19, 2022
@dantreiman dantreiman deleted the daniel/category_vocab_size_check branch October 19, 2022 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justinxzhao justinxzhao justinxzhao approved these changes

@jppgks jppgks Awaiting requested review from jppgks

@tgaddair tgaddair Awaiting requested review from tgaddair tgaddair is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dantreiman @justinxzhao