Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add bucketing_field Param to Trainer #2694

Merged
merged 6 commits into from
Oct 22, 2022
Merged

Add bucketing_field Param to Trainer #2694

merged 6 commits into from
Oct 22, 2022

Conversation

connor-mccorm
Copy link
Contributor

No description provided.

@connor-mccorm connor-mccorm changed the title Allow additional properties on trainer Add bucketing_field Param to Trainer Oct 22, 2022
@github-actions
Copy link

Unit Test Results

         6 files  +    1           6 suites  +1   3h 22m 45s ⏱️ + 47m 51s
  3 489 tests ±    0    3 366 ✔️ ±    0    79 💤 ±0  44 ❌ ±0 
10 414 runs  +107  10 126 ✔️ +101  244 💤 +6  44 ❌ ±0 

For more details on these failures, see this check.

Results for commit 1089a71. ± Comparison against base commit 74742c6.

@connor-mccorm connor-mccorm merged commit 6773a75 into master Oct 22, 2022
@connor-mccorm connor-mccorm deleted the trainer_fix branch October 22, 2022 04:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ksbrar ksbrar ksbrar approved these changes

@tgaddair tgaddair Awaiting requested review from tgaddair tgaddair is a code owner

@justinxzhao justinxzhao Awaiting requested review from justinxzhao justinxzhao is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@connor-mccorm @ksbrar