Add synthetic test data integration test utils, and use them for loss value decrease tests. #2789
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… value decrease tests.
arnavgarg1
reviewed
Nov 23, 2022
Comment on lines
+1
to
+2
| """Utilities for producing synthetic test data that is convergence-friendly.""" | ||
|
|
There was a problem hiding this comment.
Should we move this into integration_tests/utils.py?. Alternatively, we can rename this to util_synthetic_test_data.py. I'm personally in favor of the former
There was a problem hiding this comment.
Since this is a self-encapsulated set of library functions, I'd actually prefer to keep it in a separate file, also since integration_tests/utils.py is already quite large.
arnavgarg1
reviewed
Nov 23, 2022
arnavgarg1
reviewed
Nov 23, 2022
arnavgarg1
approved these changes
Nov 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.