Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AutoML libraries that use DatasetProfile instead of DatasetInfo #2802

Merged
merged 14 commits into from
Dec 5, 2022

Conversation

justinxzhao
Copy link
Contributor

@justinxzhao justinxzhao commented Nov 28, 2022

Changes:

  • create_auto_config_with_dataset_profile (mirrors create_auto_config), which uses the dataset_profile_pb2.DatasetProfile (whylogs-based) to infer feature types. A few notable API modifications:

    • dataset and dataset_profile are separate parameters, and it's an error to specify both simultaneously
    • tune_for_memory is excluded
    • include_hyperopt is a new parameter that is False by default.
  • Rename _get_hyperopt_config to get_resource_aware_hyperopt_config

  • Add proto-generated go files, which enables DatasetProfile objects to be interfaced with in go code.

  • Moves the hyperopt section of the base_automl_config.yaml to a separate function get_default_automl_hyperopt, defined in-line.

@github-actions
Copy link

github-actions bot commented Nov 28, 2022

Unit Test Results

         6 files  ±  0           6 suites  ±0   3h 35m 25s ⏱️ - 32m 27s
  3 539 tests +  2    3 464 ✔️ +  2    75 💤 ±0  0 ±0 
10 617 runs  +46  10 374 ✔️ +45  243 💤 +1  0 ±0 

Results for commit 22b627c. ± Comparison against base commit 6153df9.

♻️ This comment has been updated with latest results.

@justinxzhao justinxzhao changed the title Add mirrors of AutoML libraries that use DatasetProfile instead of DatasetInfo AutoML libraries that use DatasetProfile instead of DatasetInfo Nov 28, 2022
Copy link
Contributor

@arnavgarg1 arnavgarg1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just left some comments for minor nits

@justinxzhao justinxzhao merged commit ac9e556 into master Dec 5, 2022
@justinxzhao justinxzhao deleted the automl_whylogs branch December 5, 2022 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants