-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AutoML libraries that use DatasetProfile instead of DatasetInfo #2802
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
justinxzhao
changed the title
Add mirrors of AutoML libraries that use DatasetProfile instead of DatasetInfo
AutoML libraries that use DatasetProfile instead of DatasetInfo
Nov 28, 2022
arnavgarg1
reviewed
Dec 1, 2022
arnavgarg1
reviewed
Dec 1, 2022
arnavgarg1
reviewed
Dec 1, 2022
arnavgarg1
reviewed
Dec 1, 2022
arnavgarg1
reviewed
Dec 1, 2022
arnavgarg1
reviewed
Dec 1, 2022
arnavgarg1
reviewed
Dec 1, 2022
arnavgarg1
approved these changes
Dec 1, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Just left some comments for minor nits
connor-mccorm
approved these changes
Dec 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
create_auto_config_with_dataset_profile
(mirrorscreate_auto_config
), which uses thedataset_profile_pb2.DatasetProfile
(whylogs-based) to infer feature types. A few notable API modifications:dataset
anddataset_profile
are separate parameters, and it's an error to specify both simultaneouslytune_for_memory
is excludedinclude_hyperopt
is a new parameter that isFalse
by default.Rename
_get_hyperopt_config
toget_resource_aware_hyperopt_config
Add proto-generated go files, which enables
DatasetProfile
objects to be interfaced with in go code.Moves the hyperopt section of the
base_automl_config.yaml
to a separate functionget_default_automl_hyperopt
, defined in-line.