Catch and surface Runtime exceptions during preprocessing #2839
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinxzhao
approved these changes
Dec 13, 2022
arnavgarg1
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the existing implementation of
model.preprocess, if there is an error or exception thrown, we never get to see it because of the way our try-except-finally block is written.In particular, when preprocessing fails, the variables returned from
preprocess_for_trainingaren't set/don't exist in scope during the finally block, which causes anUnboundLocalErrorfor referencing a variable before definition.This PR updates the implementation to catch the exception and issue a RuntimeError since model training can never succeed if preprocessing the data itself fails.