Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add back missing split fields #2848

Merged
merged 3 commits into from
Dec 16, 2022

Conversation

ksbrar
Copy link
Collaborator

@ksbrar ksbrar commented Dec 16, 2022

As far as I can tell this line was too extensive for split configs, and it was responsible for the column fields being removed. I changed the function so that it only redacts type.

This is what the keys looked like before and after the original call to remove_duplicate_fields:

odict_keys(['type', 'column', 'probabilities'])
odict_keys(['probabilities'])

@ksbrar ksbrar requested a review from arnavgarg1 December 16, 2022 17:27
@github-actions
Copy link

Unit Test Results

         6 files  ±0           6 suites  ±0   3h 27m 25s ⏱️ - 26m 22s
  3 532 tests ±0    3 461 ✔️ ±0    71 💤 ±0  0 ±0 
10 596 runs  ±0  10 368 ✔️ ±0  228 💤 ±0  0 ±0 

Results for commit e063a4b. ± Comparison against base commit 5bcdf79.

@ksbrar ksbrar merged commit 3d53b2a into ludwig-ai:master Dec 16, 2022
@ksbrar ksbrar deleted the fix-missing-split-fields branch December 16, 2022 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants