Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support stratified split with low cardinality features #2863

Merged
merged 3 commits into from
Dec 21, 2022

Conversation

abidwael
Copy link
Contributor

This PR enables using stratified split even when we have a training example with cardinality = 1 in the column we're splitting on. It achieves this by separating out the examples with cardinality = 1, splitting as usual (stratified) then appending these items back to the dataframe.

@github-actions
Copy link

github-actions bot commented Dec 20, 2022

Unit Test Results

         5 files   -     1           5 suites   - 1   2h 33m 48s ⏱️ - 55m 36s
  3 539 tests +    2    3 467 ✔️ +    2    72 💤 ±  0  0 ±0 
10 428 runs   - 183  10 216 ✔️  - 162  212 💤  - 21  0 ±0 

Results for commit 1c1232e. ± Comparison against base commit 8caf81b.

♻️ This comment has been updated with latest results.

@abidwael abidwael requested a review from justinxzhao December 20, 2022 23:00
@abidwael abidwael merged commit 1483375 into master Dec 21, 2022
@abidwael abidwael deleted the fix-stratified-split branch December 21, 2022 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants